fix(build): add macOS compatibility for sed command #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
Fixed
sedcommand syntax inbuild.shto support both macOS (BSD sed) and Linux/Windows (GNU sed) environments. The script now detects the operating system using$OSTYPEand applies the appropriatesedsyntax when updatingpackage.jsonversion during dev builds.修复了
build.sh中的sed命令语法,使其同时支持 macOS(BSD sed)和 Linux/Windows(GNU sed)环境。脚本现在通过$OSTYPE检测操作系统,并在开发构建更新package.json版本时应用相应的sed语法。Changes / 改动:
darwin*)sed -i ""(BSD sed syntax)sed -i(GNU sed syntax)Motivation and Context / 背景
The original
sed -icommand without an empty string argument works on Linux/Windows but fails on macOS because macOS uses BSD sed, which requires eithersed -i ""orsed -i .bak.原始的
sed -i命令在 Linux/Windows 上可以正常工作,但在 macOS 上会失败,因为 macOS 使用 BSD sed,需要使用sed -i ""或sed -i .bak语法。This caused build failures for developers working on macOS when running dev builds.
这导致在 macOS 上工作的开发者运行开发构建时出现失败。
How Has This Been Tested? / 测试
sed -i ""syntax works correctlylinux-gnu) - usessed -imsys) - usessed -ilinux-gnu) - usessed -i在 macOS 上测试通过,并验证了 Linux 和 Windows 环境的代码逻辑。
Checklist / 检查清单
I have read the CONTRIBUTING document.
我已阅读 CONTRIBUTING 文档。
I have formatted my code with
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
I have requested review from relevant code authors using the "Request review" feature when applicable.
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
I have updated the repository accordingly (If it's needed).
我已相应更新了相关仓库(若适用)。